keyctl icon indicating copy to clipboard operation
keyctl copied to clipboard

Add support for arm64 targets

Open rzimmerman opened this issue 2 years ago • 5 comments

Add syscall IDs for arm64.

rzimmerman avatar Nov 17 '22 21:11 rzimmerman

Ping

hallyn avatar Jul 20 '23 17:07 hallyn

Well, I've accidentally pushed the same changes (closed already). So basically it works fair enough, here's my log:

/ # uname -a
Linux key-test 5.10.186-179.751.amzn2.aarch64 #1 SMP Tue Aug 1 20:51:46 UTC 2023 aarch64 Linux
/ # keyctl show
Session Keyring
 954719602 --alswrv      0     0  keyring: _ses.4b0d344fee412fdbc258b6615332aa864b94d6d3f86ac39bd42bb44f44e84320
 276939416 --alswrv      0     0   \_ user: test
/ # ./app
test
/ # keyctl print 276939416
test

tarvitz avatar Sep 13 '23 21:09 tarvitz

@jsipprell looks like several sites are using forks with this patch. Could you please merge this?

hallyn avatar Oct 03 '23 18:10 hallyn

@rzimmerman @tarvitz @arrestle Given that I assume each of us have a fork of this project with this patch, I wonder if we need to consider forking to a new community repo.

hallyn avatar Oct 13 '23 14:10 hallyn

@hallyn I don't have a proper answer for it. We required to have arm64 support, but I don't see any potential for any other architectures on our side. So @rzimmerman and mine changes (I made them accidentally because I missed this pr, but since they are trivial they look the same :) just support the current lib with a minor enhancement.

Since the mine fork is used in a client-side app which is updated from time to time, I assume I'll continue to support it (in the case if the original/this repository remains silent) from the following perspectives:

  • Security (using govulncheck for the dependencies).
  • Golang new versions compatibilities (supporting deprecations and so on).

tarvitz avatar Oct 16 '23 12:10 tarvitz