react-currency-input
react-currency-input copied to clipboard
Does Not Work with Safari
If you have multiple inputs, the last one is focused and will not unfocus on Safari (both mobile and web)
Tried many different things, but unable to get anything to work. Any suggestions?
The same issue. Could you please fix that?
I forked the code and removed the componentDidMount
and componentWillUpdate
and componentDidUpdate
functions. That did the trick
Just want to say I have the same issue over here
I'm also experiencing the same issue
I'm also having the same issue
It looks like it's not just Safari, it's iOS in general? I experience this with Chrome on my iPad as well (probably because they both use Webkit?). I haven't found a solution to this yet, so I'm considering writing my own or switching libraries.
I was having this problem as well. I ended up fixing it by commenting out
node.setSelectionRange(selectionStart, selectionEnd)
in componentDidMount
and componentDidUpdate
. This fixes the issue and doesn't seem to have a negative impact on the selectAllOnFocus
option. Not sure if it breaks other things...
Hope that helps.
Has anyone put in a pull request or does a solid fork exist? What did you end up doing @albertkim?
@acomito I wrote my own component that works for my needs - it's not production ready because it can't be configured with different currencies, formatting options, etc. but all I needed was the $ and the thousands , separator.
@albertkim The package has 1,288 downloads in the last day, are people just not supporting safari or are 1,288 people all editing the node_modules folder?
+1
Is there a reason @bkoltai's fix isn't being merged in? Would be great to get this working.....great package, but I don't understand how anyone is actually using it without Safari support.
+1. Please merge the fix!
MERGE THE FIX!!!!
Please merge
Merge please.
Same issue here... :(
@brunocsousa the library is really small. I think I just copy-pasted it into my project as a custom component. Then you need to change a line or two (see this thread of course). It's been working since then.
hey @acomito ... yeah, I just wanted to add +1 to the thread, and maybe the author of this wonderful component can update it with the solution... =]
I did the @bkoltai small hack on commenting those lines... it worked like a charm! Thank you guys.
Unfortunately the fixed proposed seems to only fix the issue on the Desktop version of Safari. The field seems unusable on an iOS mobile device :(
is this issue fixed now or not? i am experiencing this issue on safari desktop.
Does anyone have a better solution?
Still having this issue, but with Chrome too
Still having this issue, but with Chrome too
Weird, I am only having focus issues on safari. Chrome and FF work fine. It drove me crazy though before I found this.