react-currency-input icon indicating copy to clipboard operation
react-currency-input copied to clipboard

1.3.2 infinite loop of "handleFocus" on mobile safari, crashes browser

Open hughlomas opened this issue 7 years ago • 12 comments

Hey, sorry I don't have more details but had to rollback to from 1.3.2 to 1.2.6 this morning (last known working version). 1.3.2 was causing an infinite loop somewhere in the "handleFocus" function, but only on iphones. It might have been when unfocusing (blurring) the input but I didn't check exactly.

hughlomas avatar Jul 10 '17 15:07 hughlomas

If you could provide a repo that reproduces this issue that would help me debug it

aesopwolf avatar Jul 31 '17 18:07 aesopwolf

I'm having a similar problem. When I start to type in an input then the cursor jumps into the currency input.

norbajunior avatar Aug 09 '17 13:08 norbajunior

@norbajunior what version are you using?

aesopwolf avatar Aug 09 '17 17:08 aesopwolf

@aesopwolf the last one, 1.3.4.

norbajunior avatar Aug 10 '17 12:08 norbajunior

@norbajunior do you have any sample code you can provide to help reproduce this?

aesopwolf avatar Aug 10 '17 20:08 aesopwolf

@aesopwolf Sorry for the delay. I have this one https://github.com/norbajunior/currency-input/blob/master/src/App.js

Just an input text and the currency input.

Hope you can help. Thank you

norbajunior avatar Aug 14 '17 20:08 norbajunior

+1

I had this issue occur on Safari 10.1.2 desktop on Yosemite 10.10.5.

I would get an infinite loop that would crash the browser when using the latest version. Downgrading to 1.2.6 as suggested in the original post fixed the issue.

l3iodeez avatar Aug 15 '17 15:08 l3iodeez

Downgrading to 1.2.6 solved for me too

norbajunior avatar Aug 16 '17 15:08 norbajunior

Internet Explorer 11 wouldn't let you click to another input field.

Downgrading to 1.2.6 solved that as well. So looks like a serious focus issue exists.

Cyricx avatar Sep 01 '17 16:09 Cyricx

Heads up, 1.2.6 uses Number.parseFloat so it will not work on IE.

ghost avatar Sep 22 '17 19:09 ghost

@norbajunior @l3iodeez did you ever move to another lib or is everything working alright at 1.2.6?

This is also mentioned here: https://github.com/jsillitoe/react-currency-input/issues/50

acomito avatar Feb 19 '18 00:02 acomito

downgrading to 1.2.6 and still seeing an issue in safari unfortunately

EDIT: was not using a strict reference to npm version [insert head slap emojji]

acomito avatar Mar 13 '18 16:03 acomito