Bug when setting config.precision=16

[momanto]

there is a little bug when setting config.precision=16

https://github.com/jsikyoon/dreamer-torch/blob/7c2331acd4fa6196d140943e977f23fb177398b3/dreamer.py#L194

which forgets parsing config.precision, resulting still using float precision collecting data. I think it should be like below.

env = wrappers.CollectDataset(env, callbacks, config.precision)

specificly, below shows that if config.precision not passed, the code will use dtype=np.float32 instead of np.float16 as expected

https://github.com/jsikyoon/dreamer-torch/blob/7c2331acd4fa6196d140943e977f23fb177398b3/wrappers.py#L225-L230

https://github.com/jsikyoon/dreamer-torch/blob/7c2331acd4fa6196d140943e977f23fb177398b3/wrappers.py#L271-L274

[jsikyoon]

Oh thank you for pointing this out! I did not know the precision should be set for dataset collection. I will check and update.

Bests, Jaesik.

---

보낸 사람: Minghao Shao @.> 보낸 날짜: Saturday, October 14, 2023 5:46:13 PM 받는 사람: jsikyoon/dreamer-torch @.> 참조: Subscribed @.***> 제목: [jsikyoon/dreamer-torch] Bug when setting config.precision=16 (Issue #15)

there is a little bug when setting config.precision=16

https://github.com/jsikyoon/dreamer-torch/blob/7c2331acd4fa6196d140943e977f23fb177398b3/dreamer.py#L194

which forgets parsing config.precision, resulting still using float precision collecting data. I think it should be like below.

env = wrappers.CollectDataset(env, callbacks, config.precision)

specificly, below shows that if config.precision not passed, the code will use dtype=np.float32 instead of np.float16 as expected

https://github.com/jsikyoon/dreamer-torch/blob/7c2331acd4fa6196d140943e977f23fb177398b3/wrappers.py#L225-L230

https://github.com/jsikyoon/dreamer-torch/blob/7c2331acd4fa6196d140943e977f23fb177398b3/wrappers.py#L271-L274

— Reply to this email directly, view it on GitHubhttps://github.com/jsikyoon/dreamer-torch/issues/15, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFLDXI7BH7FENQCRQUZDTT3X7JGNLANCNFSM6AAAAAA6ADP3VI. You are receiving this because you are subscribed to this thread.Message ID: @.***>