mime-types
mime-types copied to clipboard
Use mime-score module to resolve extension conflicts. Fixes #36
I've pulled the logic I put together for resolving extension conflicts in [email protected]
out into it's own module. I'm using this in the latest 1.x version of mime
as well now, and thought it might make sense to use it in this module, too, so that the logic would be consistent across mime type modules in npm.
I'm more than happy to add someone from this project as a maintainer and/or transfer the module to jshttp
if there are concerns about ownership.
I love this method to make a module to contain this logic. I have no issues with where the module is or who is currently managing it :)
If you really wanted to contribute it to the jshttp organization that would be fine too and we can work through that, including joining the organization, though it would mean the package & procedures may need to be tweaked to be consistent with the rest of the organization modules. This is up to you and not a requirement for us to take a dependency on the module in any way :)
Pretty much the only technical issue currently is the declared Node.js engine on the dependency. This module declares the engine as >= 0.6
though mime-score
declares as >=4
which means that users of the current major here would start to see warnings from npm and/or install failures depending on if they have set engine strict.
I guess I can see a few different next steps here:
(1) Hold on to this PR until there is a major version of this module that is >=4
minimum.
(2) mime-score
decides to support >=0.6
, either the existing maintainers or new contributors (ex myself or someone) who volunteers to add (and help in perpetuity) with the support of those versions.
I'll get mime-score working on >=0.6
. IIRC, the only real issue I had was that mocha was failing < 4.0. Shouldn't be that big a deal to fixup.
As for contributing/joining jshttp org, that sounds cool. Let me get this PR fixed up, then we can take it from there.
Ah, crap. I guess I forgot to create a new branch for 114, so opening that PR + force pushing (in a hasty attempt to merge master) somehow caused this to close? Not sure what happened.
Since this is so long in the tooth I'm going to just start over, starting with a new issue.
Ah, I was wondering why it closed. I have done that before and caused every single PR to close on a project. It was a nightmare lmao