Bundle support?

[tehXor]

I'm coming from https://github.com/meteorhacks/meteord and am not sure if I'm missing something or if this project has no possibility to simply run .tar.gz archives created by meteor build.

If it has sorry for the inconvenience and it would be nice if you could point me to it. If not it maybe would be worth considering adding it. In my case it would be cumbersome to deploy the meteor app in question to all docker hosts without bundling it beforehand. The dev environments (which also is a little bit different from developer to developer) on the other hand have no docker so we would need to add it and change the build pipeline. Seems like a lot of effort and afaik meteor build isn't depreciated or has drawbacks or is there a problem I don't see?

[jshimko]

Sorry for the delayed response. It wasn't a quick answer, so I had to put it off for a bit. So...

The only required dependency to build this image is Docker, so I'm not sure what advantage using a bundle gives you. And the fact that everyone's dev environments differ is exactly the point of doing the build inside the container. That way, 100% of builds with this base image are guaranteed to be using the exact same tooling regardless of what OS you're using for development. If you inject your own bundle built on a non-linux OS, you'd have to rebuild any binaries once inside the container (see how MeteorD did that - it's a little gross). So doing the entire build process inside the container removes the need to handle special cases like that when a bundle comes from a different OS. If you were working on a Mac and your coworker was working on Windows and yet another coworker was working on Linux, you'd each have different build steps. That doesn't sound like an improvement to me.

I'm certainly not against adding bundle support, but I don't see a clear advantage in using it beyond personal preference. It's not necessarily that much faster or more efficient, it's definitely not less complicated, and it requires more manual steps (you have to manually build outside the container, then build the container itself - vs a single docker build that does it all and works the same way on any OS with Docker installed).

So I'd be happy to consider a PR for that addition, but I won't be likely to write that code myself any time soon because it's not terribly high on my priority list right now. Sorry I don't have a more satisfying answer.