Jon Shier

Results 164 comments of Jon Shier

Deferring this until later in the 5 development cycle.

It doesn’t really, as we could add new subclasses at any time. This issues tracks public subclassability. PRs are welcome for streaming and WebSocket request types.

Why do you need this method to be public? It's internal because it's an implementation detail of our upload handling.

`Uploadable` being `public` is a byproduct of the `UploadRequest` initializer previously being `public`. It's not really well designed for public consumption, but we'll consider it.

Thanks for the report! This is an interesting difference that doesn't make much sense. AFNetworking moves it's file like this: ```objc [[NSFileManager defaultManager] moveItemAtURL:location toURL:self.downloadFileURL error:&fileManagerError] ``` Alamofire moves it...

I'm guessing this happens because it's the safe default for file downloads, plus most users never need to make files available to other users. That being said, since the file...

I'll add this as a feature request, though it's unlikely we'll get to it for the initial Alamofire 5 release.

Investigating this a bit further, the documentation states: `This property has no effect for tasks created from nonbackground sessions.` Since this is background-only API, we'll likely need to integrate it...

We'll reevaluate this after AF5 is released.

An interesting approach. We've discussed different solutions to the huge router problem for a while and haven't yet formalized a solution. I'm currently using this protocol to break the different...