Enhanced_Steam_Firefox
Enhanced_Steam_Firefox copied to clipboard
jshackles
wishlist remove button broken
Problem STILL exists. There is literally no way to remove items from the wishlist with this plugin enabled. Clicking the wishlist button on the product-page brings you to the wishlist, and clicking 'remove' from the wishlist does nothing.
This removes functionality from the site - it should be a top-priority bug! @jshackles if someone wanted to create a PR to fix this, where should we start looking?
There is a button right at store pages "Add to wishlist" which also removes from wishlist. And it works well in Firefox 49.0.2 (latest release version).
Cant confirm about wishlist page, because right now ES does not work at steamcommunity pages.
@thomas-ashcraft Not sure what you're talking about. As I already mentioned, the "add to wishlist button" on product pages does not remove from wishlist with ES enabled, it brings you to your wishlist. And ES does work on steamcommunity.com pages (you can verify by viewing a profile and noticing all the extra links on the sidebar)
I just verified in Firefox 49.0.2, ES 7.3, on both Windows and Mac.
Enhanced Steam 7.3 is outdated and it's no surprise you're having issues with it. The latest version (8.9) can be downloaded from http://enhancedsteam.com/download/
Ah, I was checking for updates through Firefox!
With ES 8.9.1, I can verify the bug where 'remove' is broken on the wishlist itself still exists (so @jshackles my question above still stands). However, clicking "add to wishlist" on the product page now does remove the game from the wishlist. Also I can confirm ES still works on steamcommunity.com pages.
However, clicking "add to wishlist" on the product page now does remove the game from the wishlist.
It does.
Just tested it and removing games via WL page works for me... Strangely enough, the request doesn't get logged in the Network tab but it does work.
Firefox Dev. Edition 51.0a2, ES 8.9.1
@JoiNNN I forced ES functions to work at steamcommunity through cache by SuperSteam fork (turned it off immediately after it), then tested "remove" link at wishlist page with Firebug console opened, and it says:
Content Security Policy: Page parameters blocked resource downloading http://store.steampowered.com/api/removefromwishlist («connect-src http://steamcommunity.com http://steamcommunity.com https://steamcommunity.com https://api.steampowered.com/»).
Since I tested it on current release version of Firefox (49.0.2), it seems to me like it is related to WebExtensions API problems, so we should await for November 8, when FF 50 will be released (I hope so).
@thomas-ashcraft I suggest you reread what I wrote. I was agreeing with you.
@thomas-ashcraft
Content Security Policy: Page parameters blocked resource downloading http://store.steampowered.com/api/removefromwishlist («connect-src http://steamcommunity.com http://steamcommunity.com https://steamcommunity.com https://api.steampowered.com/»).
This is exactly the issue that Mozilla fixed in FF50 - any site with a stated Content Security Policy (CSP) could not have that security policy overridden by an addon. Because of this, calls to Steam's own domains (such as store.steampowered.com, in this case) wouldn't work and neither would calls to api.enhancedsteam.com which are required for many features. The only reason Enhanced Steam works at all on Firefox < 50 on the store pages is because Valve did not specify a CSP on those pages.
Firefox 50 is scheduled to release Tuesday, November 15th and includes a lot of changes to CSP and how the browser handles user-based CSP overrides. In my own testing, Firefox 50 seems to be about 99% compatible with the current Chrome feature set.