Enhanced_Steam icon indicating copy to clipboard operation
Enhanced_Steam copied to clipboard

GruntJS

Open Smashman opened this issue 10 years ago • 5 comments

http://gruntjs.com/

Worth looking into for linting and minification?

Smashman avatar Mar 26 '14 17:03 Smashman

I also chucked enhancedsteam.js through http://jshint.com/

It's not pretty and I think we oughta go through it and give it a clean up.

Smashman avatar Mar 26 '14 18:03 Smashman

Yes I agree the code could be cleaned up quite a bit, though a lot of the errors given by jshint.com revolve around $ being an undefined variable, since it's not taking into account that jQuery is loaded before enhancedsteam.js.

Anyway, I'm all for minification of the code as part of the build process before it's sent to Google.

jshackles avatar Mar 26 '14 18:03 jshackles

It notes 52 warnings in only 16% of the file, of which the undefined variables do not count. That's pretty bad :-1:

Smashman avatar Mar 26 '14 18:03 Smashman

grunt or gulp are very good. gulp have a lot of good plugins http://gulpjs.com/plugins/

sharkiller avatar Apr 03 '14 12:04 sharkiller

Gulp is pretty much worth it let alone for the JSHint feature. It also provides the ability to use some other nice things in the future.

I have worked with both gulp and grunt, and my choice would be gulp in this case.

I made a basic gulpfile that runs JSHint. #510

Saturate avatar Jun 18 '14 13:06 Saturate

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.

VanityFox avatar Aug 24 '19 01:08 VanityFox