Jonathan Grimes

Results 139 comments of Jonathan Grimes

What is the goal? Lint only modified files? or lint all files in the graph? We already have a config to only lint modified files. Though, I like the new...

We made effort to ignore files out of the graph on purpose. If memory serves, we toss a job at a worker pool for every file discovered. It doesn't wait...

Machine details would help too. I could believe this plugin is a little biased to very-wide CPUs. (ie: being less ideal for low-core counts)

`threads: number` will limit the number of threads (0 obviously disabling). `threads: boolean` will enable/disable. The default thread limit is `cpus - 1`. If it's not returning, that sounds like...

At that point, you should just use eslint directly and run it on your files via cli/watch... kinda out of scope for this plugin wouldn't you think?

> ### 1. Not only parse files on graph > * Files `.d.ts` are not linted [Some files are ignored #120](https://github.com/webpack-contrib/eslint-webpack-plugin/issues/120) > * If you want to ignore a file,...

> the issue is this line: > https://github.com/webpack-contrib/eslint-webpack-plugin/blob/4daddf5335b2c78203482d7e7f6d82a909277212/src/linter.js#L84 > > I propose getting rid of cache in src/linter.js, as we are not using it as cache at all, > maybe...

@watjurk Yes, in the **current** state of the plugin, it is useless. However, the plugin is also currently in a performance regression. See the state of it before 2.5.0... When...

Its my opinion that this is still needed, once threading is restored.