Jonathan Grimes
Jonathan Grimes
Just tested master, and these same tests fail. Running tests on v3.2.25, has simular failures. (`--check` tests, and pm2 scenarios)
I've fixed all errors on node 11. There still are errors on node 12+. Looks like Node12+ broke the `--check` support. :/ The other failures are from attempting to `require()`...
Locally on node 11, using `npm ci` to install deps, tests all pass. The tests that are failing on CI and I'm not sure why.
I've worked through many of the failures. Should be good to go. Side thought... the tests run on node configured in the build matrix. However, it also builds on those...
the build doesn’t run because dev deps aren’t installed unless you run npm/yarn install from that package. esm is a zero-dep library. it must be built and published to be...
is lint not run as a check?
I believe the errors in the test/fixtures files are intentional.
And double checked, and I haven't modified those files.
> It doesn't look like it, from studying the travis and appveyor config, it's omitted. I believe it is run by `husky` on the author's machine before push. > >...
I would fix the lint errors, but i hesitate to include orthogonal changes.