full-stack-hello icon indicating copy to clipboard operation
full-stack-hello copied to clipboard

The opcode impl hook design is inefficient

Open mlouielu opened this issue 8 years ago • 2 comments

Current design about opcode implement hook is to hook the corresponding implement to each instruction in env->insts, which the insts is read from file.

Should it be hook on an opcode impl list, then each instruction only need to call from env->impl[opcode](...), this should be more efficient for memory usage and hooking stage.

mlouielu avatar May 24 '17 03:05 mlouielu

We need map or associative data structure to hook instruction and validate as well.

jserv avatar May 24 '17 08:05 jserv

@jserv I didn't get it. what do you mean?

mlouielu avatar May 25 '17 06:05 mlouielu