react-ladda icon indicating copy to clipboard operation
react-ladda copied to clipboard

Ladda's CSS must be made part of react-ladda package

Open InamTaj opened this issue 7 years ago • 4 comments

As this package is intended for react-apps, the css file for ladda buttons must be included in the react-ladda package so that one can perform clean imports / builds in projects that use webpack + css-modules for managing CSS.

Example Usage from my app's App.js:

...
// imports of CSS styles of 3rd-party packages
import 'font-awesome/css/font-awesome.min.css';
import 'rc-slider/assets/index.css';
import 'react-datepicker/dist/react-datepicker.css';
import 'react-select/dist/react-select.css';

InamTaj avatar Aug 24 '17 11:08 InamTaj

I think you can still import the CSS from Ladda itself from its dist folder, since it gets installed with react-ladda.

austinbutler avatar Aug 06 '18 23:08 austinbutler

@austinbutler I've already checked and there is no style available in the dist folder.

InamTaj avatar Aug 07 '18 08:08 InamTaj

I am referring to the ladda module itself, not react-ladda.

image

austinbutler avatar Aug 07 '18 20:08 austinbutler

@austinbutler Yes this is what I did eventually. But the issue I opened is that the style should be included in the react-ladda so that it's easier to use.

InamTaj avatar Aug 09 '18 07:08 InamTaj