semver icon indicating copy to clipboard operation
semver copied to clipboard

Reusing commit messages instead of using a new one

Open xvs32x opened this issue 2 years ago • 2 comments

Hi! First of all, thank you for this amazing NX plugin! :)

I have NX monorepo with two apps and one shared library with module which is used by both of applications. The plugin let me to use --trackDeps option to bump versions of applications if I change something in my shared library. But I found a small issue related to the tags which were created after these changes.

For instance, I've got 2 last tags of my applications in Gitlab:

  • app1-1.0.0 - JIRA-1 Commit header example
  • app2-1.0.0 - JIRA-2 Commit header example

And then I change somethings, add commit message "JIRRA-3 Commit header example" in my library and release the changes. The plugin bumps versions of applications and create two tags with correct versions:

  • app1-1.0.1 - JIRA-1 Commit header example
  • app2-1.0.1 - JIRA-2 Commit header example

But, unfortunately it reuses the last commit for every application instead of using a new one. So, in my case, it should be something like that:

  • app1-1.0.1 - JIRA-3 Commit header example
  • app2-1.0.1 - JIRA-3 Commit header example

I was really confused when I found a lot of tags with the same commit message =)

xvs32x avatar Feb 07 '23 14:02 xvs32x

Hi, the trackDeps option is fragile and hard to maintain in its current state cf https://github.com/jscutlery/semver/issues/526, we started to rewrite @jscutlery/semver to correctly handle releasing workspace with apps and shared libraries, but this needs a full rewrite so unfortunately it won't land tomorrow.

edbzn avatar Feb 07 '23 17:02 edbzn

Hi, the trackDeps option is fragile and hard to maintain in its current state cf #526, we started to rewrite @jscutlery/semver to correctly handle releasing workspace with apps and shared libraries, but this needs a full rewrite so unfortunately it won't land tomorrow.

Let me know if I can help you to speed up this rewriting. ;)

xvs32x avatar Feb 08 '23 07:02 xvs32x