semver icon indicating copy to clipboard operation
semver copied to clipboard

feat: option to specify additional json files to update version number

Open mvrana-cen81948 opened this issue 2 years ago • 2 comments

This is critical feature we are missing during our application development. Our applications contains metadata file like version.json or info.json which is loaded by monitoring tool. So we can see our deployed version on monitoring dashboard.

mvrana-cen81948 avatar Jan 31 '23 17:01 mvrana-cen81948

Codecov Report

Merging #649 (37f6454) into main (c1a7f9e) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   97.28%   97.42%   +0.13%     
==========================================
  Files          28       28              
  Lines         590      622      +32     
  Branches       97      102       +5     
==========================================
+ Hits          574      606      +32     
  Misses          9        9              
  Partials        7        7              
Impacted Files Coverage Δ
packages/semver/src/executors/version/index.ts 98.24% <ø> (ø)
...kages/semver/src/executors/version/utils/logger.ts 100.00% <ø> (ø)
...ages/semver/src/executors/version/utils/project.ts 96.00% <100.00%> (+4.69%) :arrow_up:
packages/semver/src/executors/version/version.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jan 31 '23 18:01 codecov[bot]

Hey @mvrana-cen81948 ! Thank you for the PR. This is definitely something that we want to solve with our new custom "strategy" system.

We want to let developers choose which files to update and how.

It could be a JSON file but also a YAML file or a custom format...

That said, we still don't have an ETA and we don't want people to be stuck either.

@edbzn maybe we could add the option and mark it as "experimental"? This way, we wouldn't have to maintain it for long once the custom strategy system is out.

yjaaidi avatar Aug 05 '23 09:08 yjaaidi