semver icon indicating copy to clipboard operation
semver copied to clipboard

`nx run workspace:version` does not generate changelog

Open TriPSs opened this issue 2 years ago • 12 comments

Running nx run workspace:version does not generate changelog or updates the package.json files inside the repo.

If I delete https://github.com/jscutlery/semver/blob/main/packages/semver/src/executors/version/version.ts#L34 till https://github.com/jscutlery/semver/blob/main/packages/semver/src/executors/version/version.ts#L45 it works as expected.

TriPSs avatar Dec 08 '21 22:12 TriPSs

Hi @TriPSs, I tested and it works, did you correctly set the --syncVersions flag?

edbzn avatar Jan 05 '22 21:01 edbzn

I did not do that? Is that something that is required now?

I'm currently downgraded to 2.13.3 as I did not have the issue with that one.

TriPSs avatar Jan 05 '22 21:01 TriPSs

I assume you are using the sync mode right? It was always required, the default mode is independent, you have to pass the flag.

edbzn avatar Jan 05 '22 21:01 edbzn

Sorry for the late reply, I was indeed using syncVersions

TriPSs avatar Jan 07 '22 23:01 TriPSs

I'm not able to reproduce, can you try the latest version and tell me if it's still happening?

edbzn avatar Jan 08 '22 17:01 edbzn

I also have it with the latest version.

TriPSs avatar Jan 08 '22 23:01 TriPSs

Does the repository is open?

edbzn avatar Jan 09 '22 07:01 edbzn

I also have the same error with the latest version. FYI, I have angular.json file in codebase. nx-run-workspace-json-error

pavandixit93 avatar Jan 10 '22 12:01 pavandixit93

@pavandixit93 Can you share the repo or a minimal reproduction?

edbzn avatar Jan 25 '22 10:01 edbzn

This issues happens again in the latest release. Can we reopen @edbzn?

TriPSs avatar May 15 '22 17:05 TriPSs

@TriPSs can you give me more details on the error, are you using the latest v2.23.4?

edbzn avatar May 16 '22 08:05 edbzn

@edbzn I indeed was the latest version 2.23.4, rolling back to 2.22.0 solved it.

TriPSs avatar May 16 '22 08:05 TriPSs