Jonathan Schwender

Results 310 comments of Jonathan Schwender

Please note that `corrosion_import_crate()` despite its name does not import one crate, but potentially a whole workspace, consisting of multiple packages, each potentially with multiple crates. Therefore, I think this...

> So https://github.com/corrosion-rs/corrosion/pull/247 is still relevant. Lets's please discuss this here in this PR and not the other one then to keep things on topic. From my point of view...

> The other idea is to reach out to the cbindgen maintainers and get their thoughts on sharing an environment variable for the generated header directory so this helper function...

Responsible code is here: https://github.com/rust-lang/rust-bindgen/blob/97ab9152b5edb1fda1ced9bc1604f5e4dc9cfaa9/bindgen/codegen/mod.rs#L3679-L3683 Perhaps we could just skip forward declarations of enums, and assume that the real definition will come later in the code?

I can't reproduce this problem either. I'm suspecting that a number of the windows issues we are getting, might just be antivirus software deleting or quarantining files.

Or one of the many bundled `.dll` files

Interesting, I just tried on my work laptop and can reproduce the issue. It's wierd that I couldn't reproduce it on my personal windows machine. If I run ` .\servo.exe...

It turns out the key is `debug-assertions = false`, and it is intentional (albeit unfortunate): https://github.com/servo/servo/blob/c6c0f754529eebc9765ef9858d63f0b47a3f9424/ports/servoshell/main.rs#L17-L21 If I read [the documentation](https://doc.rust-lang.org/reference/runtime.html) correctly, then we need to choose between: a) When...

I do wonder if it might be possible to detect at runtime / startup if servo is running from a console, and redirect stdout / stderr to the console? Probably...