Julien Schueller comments

Results 519 comments of


                                            Julien Schueller

imgmath: Avoid parallel workers depth write race

hello @AA-Turner, I made the filelock module optional and passed all the tests, what do you think ?

imgmath: Avoid parallel workers depth write race

I'm trying to write a similar class from os.lockf and msvcrt.locking as suggested by @gastmaier

imgmath: Avoid parallel workers depth write race

@gastmaier @AA-Turner I successfully tested the new implementation, what do you think ?

imgmath: Avoid parallel workers depth write race

- math_outdir is the destination of math images, typically /html/_images/math/ - the DEPTH=0 lines are svg comments that are written at the end of the svg file produced by dvisvg

imgmath: Avoid parallel workers depth write race

@AA-Turner ok, I updated CHANGES/AUTHORS

imgmath: Avoid parallel workers depth write race

hello @jfbu, is there anything more I can to to get this merged ?

imgmath: Avoid parallel workers depth write race

thanks, I'll wait for feedback would it be possible to remove the "awating response" tag though ?

Add embed_code_links parameter

> Seems reasonable. > > I would add a `_bool_eval` check in `_fill_gallery_conf_defaults` for the new config. > > I think we could add a test in `test_gen_gallery.py`, using `@pytest.mark.add_conf`...

Add embed_code_links parameter

I think I need help to write a test

Add embed_code_links parameter

thanks @lucyleeow I added all in one commit