Julien Schueller

Results 523 comments of Julien Schueller

> const Indices indicesTrain(splitter.generate(indicesTest)); you could write `splitter.generate(indicesTest);`

the modules of the argument classes probably need to be added to experimentail_module.i (before LinearModelValidation inclusion)

its due to the typemaps from BoxCoxFactory not following the xxxOut naming convention and colliding with LMValidation argument name: ``` diff --git a/lib/src/Uncertainty/Algorithm/Transformation/ProcessTransformation/openturns/BoxCoxFactory.hxx b/lib/src/Uncertainty/Algorithm/Transformation/ProcessTransformation/openturns/BoxCoxFactory.hxx index f09fb0158..e15eef76e 100644 --- a/lib/src/Uncertainty/Algorithm/Transformation/ProcessTransformation/openturns/BoxCoxFactory.hxx +++...

the new integration methods should probably be attached to some integration classes rather to DOE classes

there is IntegrationAlgorithm interface class that has some `integration()` methods but with different signatures, so it would probably be a new in an unrelated class, ExperimentIntegration or something

Its difficult to review since you squashed everything together I suggest to do "reset HEAD~" (this will cancel the commit but keep modified files, and unstage the new files), a...

there seems to be a problem with your hdf5 installation: ``` Warning! ***HDF5 library version mismatched error*** The HDF5 header files used to compile this application do not match the...

you can try to disable paralelization in the tests and check if it passes: `TBB::Disable();`