textillate icon indicating copy to clipboard operation
textillate copied to clipboard

ie7 bugs

Open ghost opened this issue 12 years ago • 6 comments

I am not asking for support for the animations, but the library itself causes a js error when loaded in compatibility mode, ie7 standards in IE10. The bulk of it seems its from using .in as an object property since it is a reserved javascript keyword. Even if i change the .in to ['in'], http://code.jquery.com/jquery-1.9.1.js seems to have an issue loading at line 2582 saying member not found. Would be great to clean up the code and address these issues to at least make it load in older browsers. Thanks.

ghost avatar May 21 '13 23:05 ghost

Interesting, I definitely would have thought ['in'] would work. Obviously I did not do much testing in older browsers but I agree it should be able to load the library.

jschr avatar May 22 '13 13:05 jschr

If I have time this weekend I'll try and submit a pull request.

ghost avatar May 22 '13 18:05 ghost

i changed 'in' to '_in', it works on IE8 and 7

yuhaoboris avatar Jul 06 '13 03:07 yuhaoboris

This seems to still be an issue. I tested it in IE8. Wasn't working.

To get around it, I changed the defaults in jquery.textillate.js to my custom options. This prevented me from having to call 'in' in the jquery block of my document.

aapljack avatar Oct 03 '13 23:10 aapljack

Having same issue in IE8 with "in". Any chances next release coming soon?

rll6976 avatar Apr 30 '14 20:04 rll6976

Chiming in (!) here to say you can change in to _in as suggested. In your call code, reference _in: and in the textillate.js itself, go to line 149 (for me) and see:

if (isInEffect(options.in.effect)) {

Yes, change .in. to ._in. there.

Two lines down, do it again. And finally, animateChars($chars, options.in, function () {

As well. Very quick change.

VaelVictus avatar May 30 '14 02:05 VaelVictus