jschiefner
iOS 12 support and fix bugs
Fix lag when changing brightness and brightness changes after respring
First, I don't have any devices with iOS 13+, so I need someone to test it on other iOS.
Before (actually not as much as the video, just slightly):
https://github.com/jschiefner/advanced-brightness-slider-tweak/assets/87893636/9dbbce82-590c-4dd6-a244-bb5587b223df
After:
https://github.com/jschiefner/advanced-brightness-slider-tweak/assets/87893636/ce8b87fe-d029-45d2-ac5b-5b6e89c2451f
One problem I have is after respring, the glyph and value of slide aren't updated immediately. I don't know if the problem is my code or yours because I don't have any device to test.
It was my fault, fixed it. Still need someone to test it on newer iOS version before merging.
Cheers @NguyenASang thats a great set of contributions! I'll test it out in the coming days on my iPad that is still jailbroken on iOS 14 and i have to find other testers for iOS 13, 15 & 16, as i can't risk breaking compatibility for these platforms.
In the meantime i would like to make a test build on Github Actions - is there any way you can request to let your forked code make a CI pipeline run? I can't find any information on how to request them, just how i can approve them (https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks).
I'm not really sure how to do that. However, I just noticed that I haven't enabled the workflow on my fork, maybe that's why you can't run it?
@NguyenASang Did you enable workflows in your fork? if not please do and let's see if i can then approve it somehow.
@NguyenASang i enabled workflow runs for Pull Requests, please merge the main branch into your feature branch and push, i hope this should trigger the workflow. Also enable workflows in your fork settings if you can first.