dtrt-indent icon indicating copy to clipboard operation
dtrt-indent copied to clipboard

Published 20 hours ago • verified publisher icon jscheid

SGML support

Open saturday06 opened this issue 11 years ago • 5 comments

saturday06 avatar Mar 01 '13 16:03 saturday06

Thank you for pointing that out. I fixed my misunderstood regexp. I would like to match the regexp with html or sgml comments like as much as possible. Please re-review it.

saturday06 avatar Mar 04 '13 13:03 saturday06

Sorry I've let this one slip, I've been terribly busy with other things in the past few weeks.

This still looks fishy to me. If I'm not mistaken, it would match all of the following as comments even though they aren't:

<!x-- ... -->
<!-- ... --x>
<!-- ... --->
<!-- ... -- ... -->

The last one might be tricky (or impossible) to cover with the regexp mechanics currently offered by dtrt-indent, so I think it would be OK to ignore it for now. But the first three can be done no problem as far as I can tell.

See http://www.w3.org/TR/2008/REC-xml-20081126/#sec-comments

jscheid avatar Apr 15 '13 13:04 jscheid

@jipodine, would you like to look at the outstanding issue on this pull request, and also rebase it?

rrthomas avatar Feb 24 '15 15:02 rrthomas

Good catch, but no time for this until next week...

jipodine avatar Feb 24 '15 18:02 jipodine

Quick try, before disappearing for a while. Untested, sorry.

jipodine avatar Feb 24 '15 20:02 jipodine