Julian Scheid
Julian Scheid
`company-capf` (with `lsp-mode`.) Am I barking up the wrong tree?
Ah, interesting. I can't seem to get that to work yet with `lsp-mode 20210521.446` and `company 20210522.1921` but it's probably something at my end. Anyway, that sounds pretty close to...
~I think it's not working because `ts-ls` doesn't support `completion/insertReplaceSupport`.~ Hmm no, can't figure it out. I'll ask for help over in `lsp-mode`.
Sure, I can give it a go. Can I remove this test? https://github.com/conventional-changelog/commitlint/commit/5badf6dc08116ed3557e6c780e55764b4f07ca67#diff-c89c0216f62496bace8eebb7c6e1f9c11a6f1a1f55acbff74afb358439363b88
I meant that the test will fail after the change because `#1234` isn't an empty commit when commentChar is `$`.
Should [these instructions](https://github.com/conventional-changelog/commitlint#install-and-run) be working? It runs (`Found 0 errors`) but doesn't seem to pick up file changes in `cli.test.ts`. I'm on MacOS
Ah, `yarn test` works (but only after `yarn build`). Might want to update the instructions. All good.
Actually, can you help me understand that test case ☝️ It still passes when I comment out the line where it sets `core.commentChar` with git so that's irrelevant. `typeof opts.parserOpts.commentChar...
> So... does that mean opts.parserOpts.commentChar is ignored? What exactly is this test testing? I've worked it out, the test was broken because it checks to see if _subject_ is...
Works great now, thanks again!