OpenJSCAD.org icon indicating copy to clipboard operation
OpenJSCAD.org copied to clipboard

AMF serializer : should compress zip the XML for export

Open z3dev opened this issue 4 years ago • 1 comments

Expected Behavior

AMF by design is compressed (zip), with XML content. The AMF serializer should do this by default, and support an option to skip compression if requested.

Actual Behavior

AMF content is not compressed, only XML content.

Steps to Reproduce the Problem

  1. Create any 3D shape
  2. Select AMF from export formats
  3. Export
  4. Results are XML only

Specifications

  • Version: All
  • Platform: ALL
  • Environment: All

z3dev avatar Sep 14 '21 00:09 z3dev

I would recommend fflate instead of jszip as it is much smaller and seems to be working well, supports multithreading.

multithreading is less important for 3mf or amf or svg as usually there is only one big main file to compress, and multi threading is only for when there are multiple files to compress.

hrgdavor avatar Sep 14 '21 08:09 hrgdavor