OpenJSCAD.org icon indicating copy to clipboard operation
OpenJSCAD.org copied to clipboard

OpenSCAD translator doesn't support d in cylinder

Open KOLANICH opened this issue 7 years ago • 8 comments

Steps to Reproduce the Problem

cylinder(d=50, h=10);

Expected Behavior

should work

Actual Behavior

d is ignored

OpenJSCAD seems to have support of d

KOLANICH avatar Jul 02 '18 09:07 KOLANICH

hi @KOLANICH ! thanks for the bug report, sadly I can only re-iterate what has been said in #370 : ie the OpenSCAD => Openjscad translator is outdated , and for now not in our priorities until the next major release of JSCAD: you are more than welcome to fix that if you have the time/ capability :)

kaosat-dev avatar Jul 02 '18 12:07 kaosat-dev

OpenSCAD => Openjscad translator is outdated

I don't understand how can it be outdated when implemented right. Why doesn't it just blindly translate OpenSCAD to OpenJSCAD?

KOLANICH avatar Jul 02 '18 13:07 KOLANICH

LISP != JavaScript

Basically, a translation layer is require.

z3dev avatar Jul 02 '18 13:07 z3dev

@KOLANICH Openjscad and Openscad are totally different pieces of software , with different implementations and capabilities, based on different languages it is not as trivial as it might seem, but as always , everybody is welcome to contribute

@aleksey-bykov : I do not see the relevance of typescript in this type of conversion

kaosat-dev avatar Jul 02 '18 14:07 kaosat-dev

then what is the point of 100% mimicking interfaces of OpenSCAD if these are 2 completely different systems?

zpdDG4gta8XKpMCd avatar Jul 02 '18 14:07 zpdDG4gta8XKpMCd

@aleksey-bykov we are not trying to mimick it, we just like the OpenScad api ... up to a point : there were two different systems built a long time ago (OOP & SCAD-like), we are moving in a different direction : functional oriented, and a more coherent API without trying to copy & paste the OpenSCAD api

kaosat-dev avatar Jul 02 '18 14:07 kaosat-dev

If you wanna separate OpenJSCAD API from OpenSCAD one, I guess there should be an intermediate layer: JavaScript API mimicking OpenSCAD API perfectly, to keep the transpiler as simple and as stable as possible.

KOLANICH avatar Jul 02 '18 19:07 KOLANICH

@KOLANICH we honestly do not have the intention, time or resources to maintain multiple APIs, (single api, easier for all :) ) the scad=>jscad converter should deal with the differences, since we are re-writing pretty much every aspect of jscad, a lot of things are currently in flux, but that will quiet down once we have V2.0 out, then we can deal with updating the converter

kaosat-dev avatar Jul 03 '18 12:07 kaosat-dev