jsanders
Rename this gem to remove "angular" from it
As the README states:
Note that there is nothing AngularJS specific here, and this will work with any other front-end that implements the same scheme.
So it doesn't make sens to name it angular_rails_csrf. A better name would be javascript_rails_csrf.
Having a gem named angluar_rails_csrf in a Rails/Vue or Rails/React project is confusing.
Well, I'm not sure about it. I mean yeah it might be a bit confusing but this name has been used for ages and it would be a bit strange to rename it now, I guess? Not to mention, we'll have to rename the config options thus introducing breaking changes for many users... I'm not sure it's worth it, that's the point
Well you can of course make it smooth by allowing both names, deprecate the old name, and release a new major version renaming that gem.
this name has been used for ages and it would be a bit strange to rename it now
Sorry to me that's not a point to not rename it. It wouldn't be the first gem that would be renamed. Another option would be to open a PR in the Rails project to import this code into the framework (nowadays SPA are quite popular I guess) and then deprecate this gem.
I'll think about it. Problem is, I'm not the owner of the repo and the original maintainer is not readily available (I'll need his assistance to rename the repo at least). If you have time and desire, please open a PR with all the necessary changes. We can perhaps proceed from there