About the "titular" parameter

[devnix]

Hi! I was checking out your integration as I want to implement Omnipay instead of working directly with Redsys.

I've found that you are setting the Ds_Merchant_Titular parameter the same as Ds_Merchant_MerchantName in https://github.com/jsampedro77/sermepa-omnipay/blob/3f21458db57b9b2a66270118a4c800512cb8b541/src/Gateway.php#L38-L42

If I'm not wrong, the merchant name would be the name of your business and the "titular" parameter would be the cardholder, so it must be the complete name of the client, and not the business name at all!

Would you want a PR for this?

[jsampedro77]

Hi @devnix You are right, that parameter value is wrong. I am sorry I have not time at all to fix this, but I can merge a PR if you want to create one.

thanks,

[devnix]

Can be closed when a new tag is released?