Jonatan Samoocha
Jonatan Samoocha
Deprecate of Activity.TYPES attr in model.py (when we fully deprecate types in favor of sport_types)
Yes, we can always deprecate this later. The `TYPES` attribute is unrelated to the pydantic v2 migration.
#256 takes care of /uploads, /activities{id} (GET), and /athlete (GET).
Oops, I forgot to take into account multiple HTTP methods per endpoint, so added these to the checklist.
Allowing async requests would be a great improvement; thanks for bringing this up! > Anything that could trip us up while trying to do it? From the top of my...
It would be great if you have the time and resources to research this, as it is not entirely trivial. I'm happy to help if you have questions about the...
> If we change to `async` do we need to still support `sync` mode? I guess so. I wouldn't want to force users to deal with the added complexity of...
> Unless we wrapped some functionality around a plain multithread solution as jonatan suggested above I wasn't entirely clear, but my suggestion was to use multithreading on the user application...
#362 Adds support for `sport_type` in the `update_activity()` method. Remaining TODO: - [ ] Support `sport_type` (and deprecate `activity_type`) in `create_activity()` - [ ] Add deprecation warnings when using the...
This is not solved yet, as we don't use pydantic for creating requests.
@imtheoperator, I tried to do this, but am confronted with flask_jwt's `current_identity` being `None` in the method under test. I can see that `mock_jwt_required` is called, but `mock_identity_handler` in my...