Jan Šafránek
Jan Šafránek
@dependabot recreate
When the test was working few days ago ([job result](https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-scale-correctness/1799486923799007232), [external-provisioner log](https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-scale-correctness/1799486923799007232/artifacts/_sig-storage_CSI_Mock_volume_storage_capacity/unlimited/storage_capacity/unlimited/)), a single CreateVolume call in the test had ~ 9KB line in the provisioner log. Now ([job result](https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-scale-correctness/1802386080972935168),...
I can see the mock CSI driver logs are cut in the middle, search for `CreateVolume` and GRPC request JSON on the next log line is cut in the middle:...
This line seems to cut long lines: https://github.com/kubernetes-csi/csi-driver-host-path/blob/586ed79ac6ae87be0186bd4a4fe9589054d73199/pkg/hostpath/server.go#L108 Maybe it's `glog` (sic!), maybe `protosanitizer`.
glog seems to have 1500 character limit on log lines: https://github.com/golang/glog/blob/861d094757551d2f65d1003f0ec93bc92b254a5a/internal/logsink/logsink.go#L33 So... I would not say it's a blocker, the test was rock stable for months. Someone needs to rewrite...
/help We need to rewrite [csi-driver-hostpath](https://github.com/kubernetes-csi/csi-driver-host-path) from [glog](https://github.com/golang/glog) to [klog](https://github.com/kubernetes/klog) and check klog has a better limit. The flaky test should then start working.
/reopen we still need to tag a new csi-driver-hostpath release + maybe update the image version in couple of places
https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/178 has been merged recently, the next release will have a callback to provide a PV name. /close
Alright, I wanted to check what linters are around and if any of them would be useful, but `go vet` could be enough /close
/ok-to-test