pytorch-widedeep
pytorch-widedeep copied to clipboard
initial commit
lets see what happens
@jrzaurin summary:
- you may find the recent build of JOSS paper here
- I changed images of math formulas to latex formulas (also in readme.md and index.md)
- the paper looks "ok" now, meaning I need a short discussion with you about the attention diagrams, see note below notes:
- I noticed you included pictures with attention mechanism related diagrams in mkdocs/sources/docs/figures
- if you want to include them in the readme/indx.md then please let me know - we should also incldue them in paper.md for JOSS
- readme.md has references to docs/figures, ie deprecated sphinx documentation directory
- I believe the next step should be a sphinx documentation cleanup, we can discuss this next week
@5uperpalo can we close this PR?
@5uperpalo can we close this PR?
I think yes, please close it. According to guidelines: (I highlighted the most important phrase...)
Your paper (paper.md and BibTeX files, plus any figures) must be hosted in a Git-based repository together with your software (although they may be in a short-lived branch which is never merged with the default).
For possible future purposes, I rather downloaded this branch locally in case I decide to go through this process with some other repo in the near future :) ...