qt5-cadaques icon indicating copy to clipboard operation
qt5-cadaques copied to clipboard

Order of conditions in Forever loop is wrong

Open ScriptDevil opened this issue 10 years ago • 0 comments

back-link: ch02/index.html#console-application

forever {
        // test for empty string 'QString("")'
        if(line.isEmpty()) { continue;   }

        // test for null string 'String()'
        if(line.isNull()) { break;   }
}

should in reality be

forever {
        // test for null string 'QString()'
        if(line.isNull()) { break;   }

        // test for empty string 'QString("")'
        if(line.isEmpty()) { continue;   }
}

since isEmpty returns true even when the string is null. Your version would lead to an infinite loop. Further it should be QString() and not String().

ScriptDevil avatar Jan 08 '15 18:01 ScriptDevil