rview icon indicating copy to clipboard operation
rview copied to clipboard

Can't publish edited file

Open vlotorev opened this issue 7 years ago • 4 comments

I edit a file in app, click Edit options-> Actions-> Publish but red notification with 'Request error' text pops up.

Publushing edited commit message works without errors.

vlotorev avatar Dec 31 '17 20:12 vlotorev

@vlotorev I cannot reproduce this bug. Publishing an edited file works fine on my tests. Are always reproducible? What gerrit version? What kind of edit do you made? An edit over a new file, an edit over a modified file, a new add or modify operation over a file not previously in the change. Is it possible that someone published a new patchset whilist editing? In this last case, that is normal. Are you able to take a logcat of the error, so I can see which one is the underlaying error?

Thx.

jruesga avatar Jan 01 '18 19:01 jruesga

Are always reproducible?

No, see below.

What gerrit version?

2.14.2

What kind of edit do you made? An edit over a new file, an edit over a modified file, a new add or modify operation over a file not previously in the change.

I have a change with several PS on server. Change adds file.

In case I modify a couple of characters in the file then new PS is published ok. In case I modify file replacing all the text with text copy-pasted from buffer then publishing ends with request error and sometimes it's not. I can't provide precise steps to reproduce the issue.

Is it possible that someone published a new patchset whilist editing? In this last case, that is normal.

No.

Are you able to take a logcat of the error, so I can see which one is the underlaying error?

Probably in a cuople of weeks I be able to provide logs.

vlotorev avatar Jan 02 '18 15:01 vlotorev

By logcat, i was referring to your device logs, not the server logs (https://www.xda-developers.com/guide-sending-a-logcat-to-help-debug-your-favorite-app/). You must take the logcat after you get to reproduce the error again.

jruesga avatar Jan 03 '18 09:01 jruesga

@jruesga, I won't be able to gather logs in the nearest future. Also due to #65 I wouldn't like editing, as I won't be able to copy and save typed text.

vlotorev avatar Jan 07 '18 06:01 vlotorev