Johannes Rudolph

Results 503 comments of Johannes Rudolph

> Does that commit fix some slot release escapes somehow? > > (I've looked at the commit, but it doesn't seem to be apparent from there to me) > >...

Thanks for this analysis, @spangaer. I'm going to have a quick look if anything stands out. Have you already tried with Akka HTTP 10.2.7? In any case, a fix will...

> Which is logged and nothing more. I'm guessing the hope is that onUpstreamFailure(ex: Throwable) is invoked too, but that doesn't seem to happen. Yes, that is the assumption and...

> existing idle timeouts apply to http2 configuration only. `akka.http.server.idle-timeout` has been around for that purpose for a long time. I don't see why it wouldn't apply to WebSockets? Is...

Hi @kkonyshev, we might have misunderstood before. It's not clear to me why the expected functionality has not already been covered by the existing connection-level idle timeout. Is this fix...

Btw. 10.1.x is old by now and will only receive updates in rare cases.

> > I guess what we should do instead is to make that buffering configurable: > > > > * either by overloading the max-concurrent-stream setting on the client to...

:+1: @domitian yes, please go ahead. Thanks for taking this on.

It seems the `storeUploadedFiles` directive would almost work (it doesn't collect fields). If you look at its source code, here's where other fields are discarded: https://github.com/akka/akka-http/blob/cf152fb171fe7049deb1f6f685588a4fb5bcfec0/akka-http/src/main/scala/akka/http/scaladsl/server/directives/FileUploadDirectives.scala#L82-L87 You could try to...