warbler icon indicating copy to clipboard operation
warbler copied to clipboard

Exloded war support

Open kovyrin opened this issue 4 years ago • 5 comments

WIP exploded war support

kovyrin avatar Jun 11 '20 15:06 kovyrin

Hey I had not noticed this PR... is it not valid anymore? I think the exploded war support would be great to get working!

headius avatar Oct 26 '20 20:10 headius

Oh, sorry for not providing more context here. The PR worked for us, but then, to make things cleaner and easier for us, I decided to move away from using warbler's main class and pushed everything into pure jruby (basically, java -cp "$JRUBY_STDLIB:$JRUBY_JAR" org.jruby.Main -r rubygems -x"$ENT_SEARCH_WAR_ROOT" -S bin/enterprise-search-internal and then configuring and booting up Jetty from within our custom ruby code), so the need in warbler support for exploded wars went away.

If this kind of support may be helpful, I'd be OK with someone taking my code (which is not too different from the existing main class) and running with it, but, unfortunately, I'm not sure I have the time to push this over the finish line and get it merged.

kovyrin avatar Oct 26 '20 20:10 kovyrin

@kovyrin If you don't mind, I'll reopen this and pull in some other JRuby folks to discuss whether it's a useful feature to add. Thanks for the clarification!

headius avatar Oct 27 '20 22:10 headius

@kares @mkristian @enebo @jkutner Is this something we want to pursue?

headius avatar Oct 27 '20 22:10 headius

seems unfinished, would be nice if this was integrated with the existing (WarMain) "main" classes. we could leave it open as a draft or close, your call ...

kares avatar Mar 25 '23 11:03 kares