warbler icon indicating copy to clipboard operation
warbler copied to clipboard

Added Gem.clear_paths to bundler.erb

Open rsov opened this issue 6 years ago • 7 comments

Tried deploying with Bundler 1.16.3 and it did not seem to resolve the issues with https://github.com/jruby/warbler/issues/432

Submitting the fix again (with proper method call this time)

rsov avatar Jul 19 '18 16:07 rsov

Should fix https://github.com/jruby/warbler/issues/432, https://github.com/jruby/warbler/issues/430 and https://github.com/jruby/warbler/issues/415

rsov avatar Jul 24 '18 13:07 rsov

@rsov / @ kares : any chance this fix can be merged soon? Using the branch for this PR locally in our (JRuby 9.2.0.0) project appears to resolve the issue. I see that the Travis build is broken for one version, though. Maybe that can be addressed? Or is the preferred solution to wait for a change in bundler to be released (as mentioned in #432 ) and then hope that fixes 9.2.0.0 support?

timbogit avatar Aug 08 '18 15:08 timbogit

@timbogit I have tried it with updated version of bundler and it did not fix the issue

rsov avatar Aug 08 '18 15:08 rsov

It looks like it could not find rake-10.5 when using run_in_directory in "when frozen".

Added bundle_install to one of the top specs to install the needed version of rake. That fixed the issue

rsov avatar Aug 08 '18 20:08 rsov

Thanks so much, @rsov !

@kares : any chance this fix is acceptable, so that warbler can support JRuby 9.2.0.0?

timbogit avatar Aug 08 '18 21:08 timbogit

as noted previously, this isnt a good work-around https://github.com/jruby/warbler/issues/432#issuecomment-404799363 ... likely a JRuby 9.2 bug

kares avatar Aug 09 '18 09:08 kares

Bug appears to be still present in JRuby 9.2.1.0 :/

mungler avatar Nov 07 '18 10:11 mungler