First elements for a industrialised library

[onekiloparsec]

Hello John,

I've changed a bit the physionomy of the project, to actually make it slight more standard.

I've added a GitHub action to publish the package tp Pypi. You need to add your PYPI_USERNAME and PYPI_PASSWORD into the project secrets for it to work. Then, create manually a release on GitHub (that is. create a git tag, push it to GitHub, then create the release from That Page.

As for the rest (tests, linting, tox, documentation etc), it is hard to move on right now. It would require quite some refactoring in the code itself.

There is no obligationn of merging this PR if you feel lost. I've added a bit of documentation in the README for you to check. You may check this too: https://github.com/pypa/sampleproject

This PR may be a discussion thread first, and you decide when to merge.

[jrthorstensen]

Cédric -

Thank you! It may be a little while before I can attend to this properly, since I have some deadlines and also (I'm afraid) some health issues, which are hopefully not going to be serious.

I'll take a look as soon as I can.

			John

On Sat, 11 Jul 2020, Cédric Foellmi wrote:

Hello John,

I've changed a bit the physionomy of the project, to actually make it slight more standard.

I've added a GitHub action to publish the package tp Pypi. You need to add your PYPI_USERNAME and PYPI_PASSWORD into the project secrets for it to work. Then, create manually a release on GitHub (that is. create a git tag, push it to GitHub, then create the release from That Page.

As for the rest (tests, linting, tox, documentation etc), it is hard to move on right now. It would require quite some refactoring in the code itself.

There is no obligationn of merging this PR if you feel lost. I've added a bit of documentation in the README for you to check. You may check this too: https://github.com/pypa/sampleproject

This PR may be a discussion thread first, and you decide when to merge.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/jrthorstensen/thorsky/pull/4

Commit Summary

• Deleting .tar.gz file

• Adding a .gitignore file

• Adding a setup.cfg file for building universal wheel

• Adding a section about development in README

• Adding necessary requirements.txt for CI

• Updated README

• Following Pypa’s Sample Project setup

• Moving code files into its own folder

• Putting a real setup.py file

• Adding boostrapped .github files

  File Changes

• A .github/workflows/pythonpackage.yml (34)

• A .github/workflows/pythonpublish.yml (25)

• A .gitignore (14)

• A MANIFEST.in (8)

• M README.md (27)

• A requirements.txt (1)

• A setup.cfg (2)

• A setup.py (54)

• D thorsky.tar.gz (0)

• A thorsky/init.py (9)

• A thorsky/cartesian_bright.dat (904)

• A thorsky/observatories_rev.dat (70)

• R thorsky/pyskycalc3.py (0)

• R thorsky/thorskyclasses3.py (0)

• R thorsky/thorskyutil.py (0)

  Patch Links:

• https://github.com/jrthorstensen/thorsky/pull/4.patch

• https://github.com/jrthorstensen/thorsky/pull/4.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, orunsubscribe.[ACB7JFPLSQQG6JP46ILZVRLR3DA5LA5CNFSM4OXOMQI2YY3PNVWWK3TUL52HS4 DFUVEXG43VMWVGG33NNVSW45C7NFSM4JYOUPZQ.gif]

---

John R. Thorstensen Department of Physics and Astronomy Dartmouth College 6127 Wilder Laboratory Hanover, NH 03755

Office: 239 Wilder Hall Phone: 603 646 2869 Fax: 1446 Hinman Box 6127

[onekiloparsec]

Sorry to hear that. Of course take care of yourself! There is no hurry in anyway, it was just a little help. Come back when you want.