color_transfer icon indicating copy to clipboard operation
color_transfer copied to clipboard

source and target reverse

Open XinArkh opened this issue 4 years ago • 1 comments

I believe the original paper means that we want the source image to mimic the color performance of the target image, and output a transferred source image. However, in your implementation, the target image is instead transferred. This is what makes the following formulas inconsistent with the paper.

https://github.com/jrosebr1/color_transfer/blob/6724ccf927f2e3838ccd3f3da8b2542b79c9bf2f/color_transfer/init.py#L50-L68

XinArkh avatar Dec 15 '20 12:12 XinArkh

As I understand from the paper, the else case (i.e., preserve_paper = False) is actually the same as the paper. Am I right?

InnovArul avatar Mar 28 '21 15:03 InnovArul