Jamie Rolfs
Jamie Rolfs
I think it's worth trying to tune `dependencies.io` (or possibly using another service/bot that better suites our needs) before we remove it entirely. I'd be willing to open a PR...
If it continues to add more noise than value, however, I'd side with you 🤝 over the bot 🤖 (for the record).
Couple things worth mentioning: - This assumes [tpop/vim-git](https://github.com/tpope/vim-git) syntax for the diff (included in [vim-polyglot](https://github.com/sheerun/vim-polyglot)) - Since this plugin technically targets [hub](https://github.com/github/hub) should I supply an option to enable/disable this?
This now gracefully degrades if [tpop/vim-git](https://github.com/tpope/vim-git) isn't available. Are there other Git syntax packages we should support?
@sebinsua heh, once again, your questions/propositions follow my internal dialog/thought process pretty closely... #### 1. Supporting chaining without `within()` would be possible, but I stuck with `within()` both for Testing...
Ahaaaa, ok that's an interesting idea. It still requires `find*` to always be `await`-ed, but allows chaining a single interaction onto the `LocatorPromise`. I like it, and I don't think...
@markerikson, that's a compelling reason to get this chaining stuff in there (as if we hadn't already convinced ourselves). I also have a project with quite a few of those...
Ugh, lame, sorry about that. I'll have to see why that didn't fail the build. The biggest difference is that one works with **playwright** the library and one works with...
@markerikson, alright, I manually published **@playwright-testing-library/[email protected]**. Sorry about that. Thanks for the feedback on the confusion around the packages btw — honestly, I'd attribute some of that confusion to Playwright...
@markerikson sure thing, let me know if you run into any other issues :)