PhysicsRangeExtender icon indicating copy to clipboard operation
PhysicsRangeExtender copied to clipboard

Memory leak detected by KSPCF

Open BrettRyland opened this issue 2 years ago • 0 comments

The KSP Community Fixes mod detects a of memory leak in PRE that is easily fixable:

[KSPCF:MemoryLeaks] A destroyed PhysicsRangeExtender:PhysicsRangeExtender instance is owning a onVesselSituationChange GameEvents callback. No action has been taken, but unless this mod is relying on this pattern, this is likely a memory leak.

In OnDestroy in PhysicsRangeExtender.cs#L75

GameEvents.onVesselSituationChange.Add(SituationChangeFixes);

should be

GameEvents.onVesselSituationChange.Remove(SituationChangeFixes);

BrettRyland avatar Aug 23 '22 09:08 BrettRyland