agp-sources icon indicating copy to clipboard operation
agp-sources copied to clipboard

Published 20 hours ago • verified publisher icon jrodbx

Add a workflow for automatic updates

Open Goooler opened this issue 6 months ago • 3 comments

View the results in

  • https://github.com/Goooler/agp-sources/blob/58f8aa3864e3f2a02526f5e607f0e27895355565/.github/workflows/update-sources.yml#L24-L36
  • https://github.com/Goooler/agp-sources/actions/workflows/update-sources.yml
  • https://github.com/Goooler/agp-sources/pull/7

We have to enable @renovate-bot for this repo to track AGP updates.

  • Closes #1.
  • Closes #10.

Goooler avatar May 15 '25 09:05 Goooler

All workflows have been merged into https://github.com/Goooler/agp-sources/blob/ac23064e6529e504d1dbabbd2cccec3c60bc4c2c/.github/workflows/ci.yml.

Goooler avatar May 15 '25 10:05 Goooler

Gosh, this rule is not working...

https://github.com/Goooler/agp-sources/blob/2bf32526af0924288ee41acfc1c1b778d46ba04a/.github/renovate.json5#L12-L17

Goooler avatar May 21 '25 10:05 Goooler

Everything looks good for now.

https://github.com/Goooler/agp-sources/issues?q=is%3Apr+author%3Aapp%2Fgithub-actions

Goooler avatar May 22 '25 03:05 Goooler

image

Goooler avatar Jul 28 '25 02:07 Goooler

Oh wow, my apologies that I haven't been watching this repo closely. Love this -- let's definitely get this landed.

So, it looks like there are multiple tweaks here. Can we remove the source updates (maybe move to a separate PR and land that first to get the repo close to latest prior to the actual workflow changes?) and squash/break up what's left into discrete PRs for easier review (I promise to review them in a timely fashion!)?

Some questions off the bat:

  • why separate stable from alpha line? It'd be nice to just keep them as one, or is it related to Google's release process?
  • is there a way to determine the latest version (or versions, depending on the 1st bullet point) and cache that via some CI state to avoid the explicit script updates?

jrodbx avatar Nov 21 '25 19:11 jrodbx

You can merge #11 first.

Goooler avatar Nov 21 '25 23:11 Goooler

See comment https://github.com/jrodbx/agp-sources/pull/11#issuecomment-3565156185. I think #11 can be closed, given the discussion and we can focus/iterate on landing this.

jrodbx avatar Nov 22 '25 00:11 jrodbx

I have no interests for rebasing and rebasing again.

Goooler avatar Nov 22 '25 02:11 Goooler

I have no interests for rebasing and rebasing again.

I've pulled out the non-relevant bits into #15 if you change your mind!

jrodbx avatar Nov 22 '25 04:11 jrodbx