Jason Robbins

Results 100 comments of Jason Robbins

The one existing unit test that we have now is: https://github.com/GoogleChrome/chromium-dashboard/blob/main/pages/featuredetail_test.py#L89 The basic format of such tests is: * It is located with the tests for the handler class that...

I assigned this issue to you. And, I also added you as a collaborator on this project with write access.

We'll follow the test pattern that you established when we change from django to jinja2 templates.

As a work-around, you can use the all-features page and then select a milestone from the menu or type in the query milestone=59. https://chromestatus.com/features#milestone%3D59

I like this. It would also be good to phase out SASS. I don't think that we use it enough to justify the complexity of having it in our build...

I like the new organization. This is kind of a nit, but I'd like it better if the name of the new top-level directory could be autocompleted in one step...

This would certainly be a big improvement. Your list of things to look out for seems pretty complete. You might need to spend some time upgrading other JS libraries or...

I see your point about affecting the enclosing `` being potentially confusing in a widely reusable component. However, I would think that would be addressed by having the reusable component...

@cwilso ping on these wording changes