nokiahealth icon indicating copy to clipboard operation
nokiahealth copied to clipboard

Published 20 hours ago • verified publisher icon jrmycanady

Nokia Health is now Withings

Open pdbogen opened this issue 5 years ago • 4 comments

Hullo!

Not sure how much you want to rename everything, but.. Nokia Health is back to being Withings. Importantly, several URLs have changed and the old URLs no longer work.

I've already opened https://github.com/golang/oauth2/pull/375 to add a golang.org/x/oauth2/withings, and I have a branch that fixes the URLs within the app, renames files, adjusts strings, etc., but.... the package is still nokiahealth.

pdbogen avatar Mar 27 '19 17:03 pdbogen

ah, I guess, there are no new packages in golang/oauth2, so, we'd need to add the relevant oauth config changes to this library I guess.

pdbogen avatar Mar 27 '19 18:03 pdbogen

Yeah I have started the process of renaming everything and also updating to match the latest version of the API. I am debating if I should push the changes to a new repo and leave this for legacy or update this repo. Any suggestions would be helpful.

Also ran into packages item on oauth2. Plan to just include the URL in the library.

jrmycanady avatar Mar 31 '19 04:03 jrmycanady

I can see a few options, and I don't know which you like best. Least work to most work:

  1. Just fix things and don't worry about the repo name. Hurts discoverability.
  2. Rename the repo. Github will redirect humans. People depending on the old name will be SOL, I think, until they update.
  3. Fork the repo, get this one working just enough, with a big old warning message on the README that it's deprecated. Actively maintain only the new one.
  4. Fork the repo, and maintain both. Might be painful due to package paths.

I favor #2 or #3.

pdbogen avatar Apr 09 '19 05:04 pdbogen

I am leaning towards 3, primarily because I also want to move to go modules and I feel like that kind of justifies a fork as well.

jrmycanady avatar Apr 10 '19 02:04 jrmycanady