James Kerns

Results 125 comments of James Kerns

I see. That looks like it's several slices off. The HU-finding algorithm appears to be skewed here. I've not seen this phantom before. what model is it? Is that the...

All right, it's been a while since I looked at the 604 =). I will add some comments.

From what I can tell this appears to be unique to the 604. The 604 makes some of the HU ROIs longer than the others. I don't know why. ![image](https://user-images.githubusercontent.com/4803336/195646047-9fe0f742-ad2e-4d6d-9f80-aaffbb1a3aa7.png)...

Well, well. This is what happens when you don't have a good memory. Changing the defaults would work in theory. I can try that as an alternative and see if...

@crcrewso This may have been a 500 IQ call. I played around with the default for 604 and things seemed to work out nicely. @keithoffer Either 1) In the source...

@crcrewso Elegance is in the eye of the beholder. A one-line change seems far more preferable than many. I think we can all agree that the 604 center-finding needs tweaking....

@crcrewso I'm not against a refinement method, but the method is already overridable. ``` class MyCatPhan(CatPhan604): def find_origin_slice(self): default_hu_slice = super().find_origin_slice() # do whatever here to get a refined value...

I'm still confused as to what you actually want. Can you write up a boilerplate code example of what you think the user should be doing when they want to...

Good point. I need to add an `invert=True` parameter to the analyze method, which should address this. Would you mind uploading a set of these images I can test. https://forms.gle/kvbwZ4Q9dfvi8BtT6

This appears to be unrelated to the inversion. There are a few issues going on here I can't fully grasp. First, there is a significant artifact in the G270 image...