web-resource-inliner icon indicating copy to clipboard operation
web-resource-inliner copied to clipboard

How to deal with svg fill urls?

Open tommedema opened this issue 7 years ago • 1 comments

I'm not an expert on svgs, but apparently the fill attribute can have anchors that are referencing to svg definitions like so:

screen shot 2017-12-23 at 16 28 24

In this case the given url should not be embedded, since it is a reference rather than something you can base64 encode. Right? What's your take on this?

tommedema avatar Dec 23 '17 08:12 tommedema

I think you might be a level deeper on SVGs than I had considered. The docs around SVG are focused on inlining SVG files into HTML content, rather than inlining the content within SVGs. In any case, my understanding (which could be wrong) is that if one wanted to inline that reference, they could and the datatype would be data:image/svg+xml but nobody has ever actually requested this as a feature so my inclination is that it would be more practical if this is causing you a problem to open a PR to exclude hashes from url inlining rather than add support for inlining SVG within SVG.

jrit avatar Dec 25 '17 14:12 jrit