Jarrett Widman

Results 43 comments of Jarrett Widman

`addImportantToPseudoClasses` ? I'm also not very active in the codebase the last few years, there is very good test coverage so don't be afraid to dive in

I have a feeling this is happening in one of the dependencies juice uses, but I agree this is a problem. A PR to fix this would be most welcome.

I don't remember where that might be getting modified, but I suspect it is in a dependency. If you can track down where that needs to be changed, I'd fully...

This is one of those little utility things that I feel like would be on npm already but I can't find anything. I'd probably just write a separate node module...

I get what you want there, makes sense. Juice is mainly designed to inline CSS using the same sorts of priority as an HTML renderer would given the same markup,...

thanks for the suggestion, would love a PR to make this work.

You could more easily achieve the same result in most situations by just wrapping the CSS you don't want inlined into a media query like `@media all { .very-generic-selector {...

That is a good suggestion for efficiency and I also like that it is not an actual CSS selector, so if someone was writing CSS that they wanted to use...

mensch returns the comments, so it'd be looking for `if (rules[i].type == 'comment') { ` I think. And then I think within juice's parseCSS function there you'd want to interpret...

This is an interesting idea. I'm not sure that I'll have time to do this, but would accept a pull request for this. What is your use case for this?