traingenerator
traingenerator copied to clipboard
Add mlflow tracking
First of all thanks for the project, it's an interesting way to take a stab at reducing the amount of boilerplate needed even for fairly simple models. Secondly, it would be interesting to implement experiment/run tracking using MLflow.
Have a working example on the Image classification_PyTorch/
template, happy to submit a PR if you consider this of any interest.
English is not my native language; please excuse typing errors.
@EbilPanda Hi, thank you very much for PR. It's really great. But he will lead to incorrect disable day, I changed your code:
- this.options.range_beg = firstDayOfYear.getTime();
- this.options.range_end = lastDayOfYear.getTime();
+ // this.options.range_beg = firstDayOfYear.getTime();
+ // this.options.range_end = lastDayOfYear.getTime();
Do you have any opinion?
hmm are you sure? because before setting the range I'm kind of checking start/end:
if(firstDayOfYear.getTime() < this.options.start) {
firstDayOfYear = new Date(this.options.start);
}
if(lastDayOfYear.getTime() > this.options.end) {
lastDayOfYear = new Date(this.options.end);
}
but if you're right (haven't checked atm) -> is disabling them the right way? or just another check needed? maybe something like that:
// checking whether the start is after firstDayOfYear
this.options.range_beg = firstDayOfYear.getTime() < startTime ? startTime : firstDayOfYear.getTime();
// checking whether the end is before lastDayOfYear
this.options.range_end = lastDayOfYear.getTime() > endTime ? endTime : lastDayOfYear.getTime();