traingenerator icon indicating copy to clipboard operation
traingenerator copied to clipboard

Add pre-commit hook for Black formatting

Open andodet opened this issue 4 years ago • 0 comments

Summary

Thanks for the interesting package, I can see it softening the burden of writing lots of boiler-plate code for standard-ish modeling tasks.

I've noticed code formatting with black is enforced in CONTRIBUTING.md. Might be a good idea to add a pre-commit hook to take that out of the equation when reviewing pull requests.

Details

Checklist

  • [x] all tests are passing (see README.md on how to run tests)
  • [ ] if you created a new template: it contains a file test-inputs.yml, which specifies a few input values to test the code template (the test is then automatically run by pytest)
  • [ ] you formatted all code with black
  • [ ] you checked all new functionality live, i.e. in the running web app
  • [ ] any generated code is formatted nicely, both in .py and in .ipynb ("nicely" = comparable to the existing templates)
  • [ ] you added comments in your code that explain what it does
  • [x] the PR explains in detail what's new

andodet avatar Jan 08 '21 18:01 andodet

你好,首先感谢你的issues。 我无法通过你的描述定位问题

可以的话我需要你告诉我以下信息: 1.在项目目录下执行 ionic info命令获取开发环境。 2.package.json 中 devDependencies与dependencies字段内容。 3.告诉我你的设备系统

hsuanxyz avatar Apr 21 '17 15:04 hsuanxyz

你GitHub的demo。

2017年4月22日 01:28,"Hsuan Lee" [email protected]写道:

你好,首先感谢你的issues。 我无法通过你的描述定位问题

可以的话我需要你告诉我以下信息: 1.在项目目录下执行 ionic info命令获取开发环境。 2.package.json 中 devDependencies与dependencies字段内容。 3.告诉我你的设备系统

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HsuanXyz/ion2-calendar/issues/11#issuecomment-296222782, or mute the thread https://github.com/notifications/unsubscribe-auth/AShXM_5Ahv-FGbI_8JbIHeJ3N7Dx3gTYks5ryMscgaJpZM4NEbt4 .

chenbobowu avatar Apr 21 '17 15:04 chenbobowu

@chenbobowu 我demo现在是开发环境,依赖并不稳定(表示歉意) 你可以新建一个项目然后在通过npm安装最新的发行版。

hsuanxyz avatar Apr 21 '17 15:04 hsuanxyz

我装最新的ionic3运行不了。typescript版本高了要修改成import Moment from moment才行。但是也是有这个Bug存在。

chenbobowu avatar Apr 21 '17 16:04 chenbobowu

好的,我会在生成一个新的环境尝试重现。再次感谢

hsuanxyz avatar Apr 21 '17 16:04 hsuanxyz

太客气了。我们谢谢你写这么好的插件才对。

2017年4月22日 02:25,"Hsuan Lee" [email protected]写道:

好的,我会在生成一个新的环境尝试重现。再次感谢

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HsuanXyz/ion2-calendar/issues/11#issuecomment-296237829, or mute the thread https://github.com/notifications/unsubscribe-auth/AShXMzfB1L3YORbcQ1ucjIxFyuoLHsKLks5ryNiHgaJpZM4NEbt4 .

chenbobowu avatar Apr 21 '17 16:04 chenbobowu

Contributing Fork it! Create your feature branch: git checkout -b my-new-feature Commit your changes: git commit -am 'Add some feature' Push to the branch: git push origin my-new-feature Submit a pull request :D

Development cd ion2-calendar npm install npm run build

output ./dist files

你好。 我Fork了Repo, 然后git clone到本地,接着创建支线。。。

然后我就想开发啦,但是我不知道怎么在本地测试这个src 或者是NPM生成的disk文件, 因为demo连接都不是连接本地的,我要开发只能修改src module,然后import module到Demo里面,最后bulid disk文件。。

不太懂git怎么合作,求教简单方法。。

我试了下: cd ion2-calendar npm install npm run build (不成功)

chenbobowu avatar May 10 '17 07:05 chenbobowu

报什么错

hsuanxyz avatar May 10 '17 07:05 hsuanxyz

C:\Users\George\Desktop\ion2-calendar>npm run bulid npm ERR! Windows_NT 6.1.7601 npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\ node_modules\npm\bin\npm-cli.js" "run" "bulid" npm ERR! node v4.6.1 npm ERR! npm v3.10.8

npm ERR! missing script: bulid npm ERR! npm ERR! If you need help, you may report this error at: npm ERR! https://github.com/npm/npm/issues

npm ERR! Please include the following file with any support request: npm ERR! C:\Users\George\Desktop\ion2-calendar\npm-debug.log

chenbobowu avatar May 10 '17 08:05 chenbobowu

npm run build 不是 npm run bulid 之后组件会编译,然后自动拷贝到demo下

cd demo 
ionic serve

hsuanxyz avatar May 17 '17 02:05 hsuanxyz