djangocms-cascade icon indicating copy to clipboard operation
djangocms-cascade copied to clipboard

WIP Adding logic fallback for image/picture/jumbotron

Open haricot opened this issue 5 years ago • 4 comments

haricot avatar Oct 20 '19 09:10 haricot

I somehow don't like to use random colors as fallback. Reason is that it adds a layer of unpredictability to the outcome. If a users want randomness, he shall explicitly set it.

Could you please explain what this PR does. A few lines of text would be great.

Thanks

jrief avatar Oct 23 '19 18:10 jrief

The goal is to have fallbacks with the widths and heights most resembling possible. I try to redo it differently. I delete the random color which is useless because there are random x y for logos, which makes it possible to differentiate the images, as in a carousel.

haricot avatar Oct 24 '19 16:10 haricot

Accurate Fallback image: (also work when resize window) accurate_fallback_image

haricot avatar Oct 25 '19 10:10 haricot

Accurate Fallback picture: (also work when resize window, we do not see the logos because the image origin is big) Acurate_fallback_picutre3

haricot avatar Oct 26 '19 12:10 haricot