django-admin-sortable2 Django 5.0 support

Jan 03 '24 10:01 khasbilegt

@jrief could you please take a look at this and approve the workflows to run?

Jan 04 '24 05:01 khasbilegt

@jrief the workflows should pass now.

Jan 04 '24 10:01 khasbilegt

@jrief I don't think I've added a change that might cause a dependency build to fail, haven't I? I think I can updating the setuptools and wheel via python pip, however why not use the pip provided by the setup-python action in the first place? What do you think?

Jan 04 '24 10:01 khasbilegt

Hello @jrief, I found out the reason why the workflow was failing and there were two issues.

Previously, the setup python action didn't specify the python version explicitly. Hence, the action used the python version that was initially set in the PATH. Basically the python version is determined by the whichever matrix instance that is successfully executed the setup-python first. If the python 3.6 and django 4.0 ran first then rest of the instances will use python 3.6. So I added python-version option in the action. Also I updated the action version to v5.
Python 3.12 support was added in Playwright version 1.39.0. So I had to bump Playwright, Greentlet and asgiref versions.

Even though I was able to fix to those, I couldn't figure out the e2e inline test (test_e2e_inline.py::test_drag_down) that's failing. Could you please help me figure out why is this test failing?

Jan 08 '24 05:01 khasbilegt

Even though I was able to fix to those, I couldn't figure out the e2e inline test (test_e2e_inline.py::test_drag_down) that's failing. Could you please help me figure out why is this test failing?

Okay, I'll have a look. Thanks for fixing the workflow.

Jan 08 '24 07:01 jrief

@khasbilegt just to validate: I have failing tests with django 5 where a template file is missing:

django.template.exceptions.TemplateDoesNotExist: adminsortable2/edit_inline/tabular-django-5.0.html

would this be resolved with admin-sortable being compatible with django 5?

Jan 15 '24 14:01 herrbenesch

Yes it will

Jan 15 '24 14:01 khasbilegt

Thank you for working on this. I'm looking forward to the fix! In the meantime, In case anybody else is stuck waiting, here's a workaround:

Create two new templates: adminsortable2/edit_inline/stacked-django-5.0.html and adminsortable2/edit_inline/tabular-django-5.0.html in your templates directory
Copy-paste the contents of the 4.2 versions of those files from your site-packages/adminsortable2/templates/adminsortable2/edit_inline/<stacked or tabular>-django-4.2.html files. This should fix the TemplateDoesNotExist error.

I wonder, would it be possible to cause Django to default to the newest available template if the Django version exceeds the highest template version available?