Jacob Rief comments

Results 514 comments of


                                            Jacob Rief

Incomplete license information

The LICENSE file has an exception to handle to special case.

Update docs for related model collections

Thanks. I will merge this in 1.5.1. When redefining the models, I first have to migrate the models on the documentation site.

Update docs for related model collections

Thanks for this pull request

Update docs for related model collections

@SamuelJennings I still find it unintuitive having to use the same attribute name when referring a form collection with siblings as specified in the connecting `ForeignKey` using the `related_name`, on...

Update docs for related model collections

`reverse_accessor` might even be a better option. I like it. And this term is used by the Django documentation itself: https://docs.djangoproject.com/en/5.2/ref/models/fields/#django.db.models.ManyToManyField.through It's also shorter to write, 16 instead of 20...

Ordering actions still rendered in action dropdown even if user don't have change permission.

Fair point. I have to fix that.

Ordering actions still rendered in action dropdown even if user don't have change permission.

@drowsyzen you can come up with a pull request. I then will review it.

Ordering actions still rendered in action dropdown even if user don't have change permission.

In my opinion the `change_` permission would be appropriate. An alternative would be to add a custom permission to the model's `Meta`-class, say `[("reorder", "Can reorder items")]` as described here:...

Selected ordering is not preserved when using "Save as new"

Thanks @ldeluigi for this pull request. Please be patient, I need some time to test this. I am just wondering, if this might cause some regressions, otherwise that comparison wouldn't...

Selected ordering is not preserved when using "Save as new"

@nicolochiellini @ldeluigi I just tested this in my local environment. In my setups the value of `order_field_value` is always `None` and therefore it always works. How is it possible that...